done #192
Open
done #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Sep 15, 2024
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
|
|
||
| @Column(nullable = false) |
|
|
||
| @RequiredArgsConstructor | ||
| @Service | ||
| public class PullDataServiceImpl implements PullDataService { |
There was a problem hiding this comment.
Suggested change
| public class PullDataServiceImpl implements PullDataService { | |
| public class CharacterClientImpl implements CharacterClient { |
|
|
||
| @RequiredArgsConstructor | ||
| @Component | ||
| public class RickAndMortyClientImpl implements RickAndMortyClient { |
There was a problem hiding this comment.
Suggested change
| public class RickAndMortyClientImpl implements RickAndMortyClient { | |
| public class CharacterServiceImpl implements CharacterService { |
| @RequiredArgsConstructor | ||
| @Service | ||
| public class PullDataServiceImpl implements PullDataService { | ||
| @Value("https://rickandmortyapi.com/api/character") |
There was a problem hiding this comment.
Suggested change
| @Value("https://rickandmortyapi.com/api/character") | |
| @Value("${rick-and-morty.url}") |
add rick-and-morty.url=https://rickandmortyapi.com/api/character to application.properties
| import org.springframework.web.client.RestTemplate; | ||
|
|
||
| @RequiredArgsConstructor | ||
| @Service |
There was a problem hiding this comment.
Suggested change
| @Service | |
| @Component |
Comment on lines
10
to
12
| public long count(); | ||
|
|
||
| public List<CharacterRickAndMorty> findByNameContaining(String name); |
There was a problem hiding this comment.
Suggested change
| public long count(); | |
| public List<CharacterRickAndMorty> findByNameContaining(String name); | |
| long count(); | |
| List<CharacterRickAndMorty> findByNameContaining(String name); |
Elena-Bruyako
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.